Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dotnet exec to run test app in CheckTargetFrameworkDisplayName #45332

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

akoeplinger
Copy link
Member

"dotnet run" does some additional steps like restore and build that we don't need and it can cause issues with additional characters in stdout like in #45042 (comment)

Switch to executing the built .dll directly.

"dotnet run" does some additional steps like restore and build that we don't need and it can cause issues with additional characters in stdout like in dotnet#45042 (comment)

Switch to executing the built .dll directly.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 5, 2024
@akoeplinger akoeplinger requested a review from nagilson December 5, 2024 13:46
@akoeplinger akoeplinger merged commit 981b74b into dotnet:main Dec 17, 2024
38 checks passed
@akoeplinger akoeplinger deleted the improve-test branch December 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants