Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/9.0.2xx] Copy dump file to the Helix upload location #45385

Merged
merged 6 commits into from
Dec 13, 2024
Merged

[release/9.0.2xx] Copy dump file to the Helix upload location #45385

merged 6 commits into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2024

Backport of #45345 to release/9.0.2xx

/cc @marcpopMSFT

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 9, 2024
@marcpopMSFT
Copy link
Member

marcpopMSFT commented Dec 9, 2024 •
edited
Loading

@Evangelink any idea why the dotnet test hang timeout didn't trigger?

Both of these timed out after 60 minutes even though the dotnet test timeout is set to 15.

+ dotnet test Microsoft.NET.Build.Tests.dll -e HELIX_WORK_ITEM_TIMEOUT=01:00:00 -e DOTNET_SDK_TEST_EXECUTION_DIRECTORY=/private/tmp/helix/working/B3EE094A/w/AF5B09A8/e/testExecutionDirectory --results-directory ./ --logger trx --blame-hang --blame-hang-timeout 15m --filter 'Microsoft.NET.Build.Tests.GivenThatWeWantToReferenceAProject+ReferenceBuildResult|Microsoft.NET.Build.Tests.GivenThatWeWantToResolveConflicts|Microsoft.NET.Build.Tests.GivenThatWeWantToResolveRuntimePackAssets|Microsoft.NET.Build.Tests.GivenThatWeWantToRunFromMSBuildTarget|Microsoft.NET.Build.Tests.GivenThatWeWantToSetPropertiesInDirectoryBuildProps|Microsoft.NET.Build.Tests.GivenThatWeWantToTargetEolFrameworks' --
VSTest version 17.12.0 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
['Microsoft.NET.Build.Tests.dll.20' END OF WORK ITEM LOG: Command timed out, and was killed]

[xUnit.net 00:59:46.07] Microsoft.NET.Publish.Tests: [Long Running Test] 'Microsoft.NET.Publish.Tests.GivenThatWeWantToPublishReadyToRun.It_supports_crossos_arch_compilation(targetFramework: "net9.0", runtimeIdentifier: "linux-x64", sdkSupportedOs: "windows,linux,osx", sdkSupportedArch: "X64,Arm64", composite: "_", selfcontained: "_")', Elapsed: 00:57:28
['Microsoft.NET.Publish.Tests.dll.6' END OF WORK ITEM LOG: Command timed out, and was killed]

This was referenced Dec 9, 2024
Open
Open
Open
@marcpopMSFT marcpopMSFT merged commit 633b882 into release/9.0.2xx Dec 13, 2024
28 of 31 checks passed
@marcpopMSFT marcpopMSFT deleted the backport/pr-45345-to-release/9.0.2xx branch December 13, 2024 21:09
Forgind
Forgind reviewed Jan 3, 2025
View reviewed changes
test/UnitTests.proj
@@ -121,6 +121,7 @@
<HelixPreCommands Condition="!$(IsPosixShell)">call %HELIX_CORRELATION_PAYLOAD%\t\RunTestsOnHelix.cmd $(TestFullMSBuild);$(HelixPreCommands)</HelixPreCommands>
<HelixPreCommands Condition="$(IsPosixShell)">. $HELIX_CORRELATION_PAYLOAD/t/RunTestsOnHelix.sh;$(HelixPreCommands)</HelixPreCommands>
<HelixPostCommands Condition="!$(IsPosixShell)">PowerShell -ExecutionPolicy ByPass "dotnet nuget locals all -l | ForEach-Object { $_.Split(' ')[1]} | Where-Object{$_ -like '*cache'} | Get-ChildItem -Recurse -File -Filter '*.dat' | Measure";$(HelixPostCommands)</HelixPostCommands>
<HelixPostCommands>PowerShell -ExecutionPolicy ByPass "Get-ChildItem -Recurse -File -Filter '*hangdump.dmp' | Copy-Item -Destination $env:HELIX_WORKITEM_UPLOAD_ROOT";$(HelixPostCommands)</HelixPostCommands>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeloff made a great point on this:
PowerShell doesn't generally exist on mac. We should use something else (wget?).

@kasperk81
Copy link
Contributor

@marcpopMSFT 9.0.2xx releases are stuck for three weeks. last release is from 6d67e2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Forgind Forgind Forgind left review comments

@dsplaisted dsplaisted dsplaisted approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcpopMSFT @kasperk81 @dsplaisted @Forgind