Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all test sdk references to the latest version. #45548

Open
wants to merge 1 commit into
base: release/9.0.1xx
Choose a base branch
from

Conversation

marcpopMSFT
Copy link
Member

I don't think we have a good way of doing the version listed in the versions.props in a test itself (rather than a test asset built ahead of time). Open to suggestions on how to solve that.

For the rest, I don't know if the test infrastructure for those tests includes the version.props which could limit how many of these I can update.

@marcpopMSFT
Copy link
Member Author

@dotnet/dotnet-testing I was talking with @Evangelink and he noticed that we had a bunch of old microsoft.net.test.sdk references so I tried to update them all.

Microsoft.NET.ToolPack.Tests.GivenThatWeWantToTestPackAToolProject.Microsoft.NET.ToolPack.Tests.GivenThatWeWantToTestPackAToolProject.When_app_project_reference_a_library_it_flows_to_test_project is failing with an odd error now that I updated the test sdk version. Anything you've seen before? Any suggestions? I'm not sure why it's timing out.
Failed to negotiate protocol, waiting for response timed out after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.

Copy link
Member

@MiYanni MiYanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Almost sounds like we should have a Version.props file just for the tests? Like, I see the fixed xunit versions in here too. I think all the tests should have a central location for their test packages, unless the test is testing a specific version of a package.

@Evangelink
Copy link
Member

Failed to negotiate protocol, waiting for response timed out after 90 seconds. This may occur due to machine slowness, please set environment variable VSTEST_CONNECTION_TIMEOUT to increase timeout.

This is a quite common issue with VSTest but it can have many sources. I'll try to read the logs next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants