Adding ClassLibrary (.NET Core) and Creating new VSIX for ClassLibrary (.NET Standard) #510
Conversation
| <Metadata> | ||
| <Identity Id="45474e92-a5d6-4ffb-8689-d7e8064cec90" Version="|%CurrentProject%;GetBuildVersion|" Language="en-US" Publisher="Microsoft" /> | ||
| <DisplayName>CSharp Standard Templates</DisplayName> | ||
| <Description xml:space="preserve">CSharp Standard Templates</Description> |
There was a problem hiding this comment.
The DisplayName and Description should probably be "C# .NET Standard Templates".
There was a problem hiding this comment.
Yes. Can we also make the project name\folder name be CSharpNetStandardTemplatesSetup?
There was a problem hiding this comment.
Do the display name for the template vsixes surface to the user?
There was a problem hiding this comment.
Normally yes (in the extension manager dialog). However since these VSIXes will be marked as Productcomponent they won't show up in the package manager dialog. So no.
There was a problem hiding this comment.
Good because otherwise we have missed loc strings ;)
There was a problem hiding this comment.
I did add a new string in roslyn project system dotnet/project-system#965
There was a problem hiding this comment.
Yes thanks. This is a different string that doesn't surface if I've understood correctly
| <Metadata> | ||
| <Identity Id="45474e92-a5d6-4ffb-8689-d7e8064cec90" Version="|%CurrentProject%;GetBuildVersion|" Language="en-US" Publisher="Microsoft" /> | ||
| <DisplayName>CSharp Standard Templates</DisplayName> | ||
| <Description xml:space="preserve">CSharp Standard Templates</Description> |
There was a problem hiding this comment.
Yes. Can we also make the project name\folder name be CSharpNetStandardTemplatesSetup?
| <ProjectTypeGuids>{82b43b9b-a64c-4715-b499-d71e9ca2bd60};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids> | ||
| <ProjectGuid>{440F1724-1830-4C7A-9500-8D9323A7FE71}</ProjectGuid> | ||
| <OutputType>Library</OutputType> | ||
| <AssemblyName>CSharpStandardClassLibrary</AssemblyName> |
There was a problem hiding this comment.
Call these projects CSharpNetStandardClassLibrary as well?
jinujoseph
force-pushed
the
SplitTemplates
branch
from
eb024b2
to
7aaffdf
Compare
jinujoseph
force-pushed
the
SplitTemplates
branch
from
7aaffdf
to
8e90665
Compare
Adding Authoring for NetStandard Templates
jinujoseph
force-pushed
the
SplitTemplates
branch
from
8e90665
to
bfc2084
Compare
|
Thanks @dsplaisted this should be now ready for review :-) |
jinujoseph
changed the title
|
|
||
| <ItemGroup> | ||
| <MergeManifest Include="$(OutputPath)\Microsoft.VisualStudio.Templates.CSharp.NetStandard.json" /> | ||
| <MergeManifest Include="$(OutputPath)\Microsoft.NET.Sdk.json" /> |
There was a problem hiding this comment.
This shouldn't include the NET SDK - otherwise the same component is being included in two vsmanprojs. Ideally we should split out the SDK into a separate vsmanproj later when we move to the model for pulling in unzipped sdks.
…310.1 (dotnet#510) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19160.1
fixes #441
@srivatsn @dsplaisted