Manually update Microsoft.Private.Intellisense to 8.0.0-preview-20230918.1 #787
Conversation
carlossanlop
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
carlossanlop
changed the title
|
Do I/we need to do something special to make sure this works for |
|
Did you forget to add Microsoft.Private.Intellisense.8.0.0-preview-20230828.1.csproj? Your previous PR included a CSProj. |
|
@ericstj I actually explicitly removed that folder since we now have a new package version, but I might have misunderstood the purpose of deletion, because I can see the CI failure is expecting the files from that package to exist. Do you know why it is still expected? |
|
Maybe it's because I haven't merged the two PRs that bump the expected package version in Versions.props in main and release/8.0. Is that why? |
|
I just realized that's the old version, probably something still sees it. Lets find out why. |
|
Here it is: |
|
Thanks, @ericstj, good catch. |
@carlossanlop - You'll need to manually port this to the release/8.0 branch here if you want the dependency flow to target 8.0 branches. |
| @@ -24,7 +24,7 @@ | |||
| Format: | |||
| <DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.Extensions.Options.5.0.0.csproj" /> | |||
| --> | |||
| <DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\microsoft.private.intellisense\8.0.0-preview-20230828.1\Microsoft.Private.Intellisense.8.0.0-preview-20230828.1.csproj" /> | |||
| <DependencyPackageProjects Include="$(RepoRoot)src\textOnlyPackages\src\microsoft.private.intellisense\8.0.0-preview-20230918.1\Microsoft.Private.Intellisense.8.0.0-preview-20230918.1.csproj" /> | |||
There was a problem hiding this comment.
@MichaelSimons - For a version upgrade like this, is this acceptable to change the version in Build.props like this?
There was a problem hiding this comment.
Generally no but it is OK for this package because we know no other SBRP packages reference it.
|
/backport to release/8.0 |
|
The backporting bot is not enabled in this repo so I'll do it manually. |
…918.1 (dotnet#787) * Add 8.0.0-preview-20230918.1 * Delete 8.0.0-preview-20230828.1 * Update Build.props DependencyPackageProjects version.
…918.1 (dotnet#787) * Add 8.0.0-preview-20230918.1 * Delete 8.0.0-preview-20230828.1 * Update Build.props DependencyPackageProjects version.
Similar to #774
Ran this command:
I also made sure to delete the old files.
Workaround for dotnet/runtime#77004
Theoretically, this should unblock dotnet/runtime#92255 and dotnet/runtime#92254
@mthalman @ericstj