Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ArPow] Re-enable sourcelink #1693

Closed
dagood opened this issue Jul 31, 2020 · 1 comment
Closed

[ArPow] Re-enable sourcelink #1693

dagood opened this issue Jul 31, 2020 · 1 comment
Assignees
@crummel
Labels
area-product-experience Improvements in the end-user's product experience area-upstream-fix Needs a change in a contributing repo

Comments

@dagood
Copy link
Member

dagood commented Jul 31, 2020

dotnet/sourcelink#629 is an issue for the current source-build plan, worked around by disabling sourcelink in dotnet/source-build-reference-packages#133.

When fixed and uptaken by Arcade, we can enable sourcelink in 5.0.

(Filing this a little early, to make sure it ends up tracked.)
@dagood dagood added area-upstream-fix Needs a change in a contributing repo area-product-experience Improvements in the end-user's product experience labels Jul 31, 2020
@dagood dagood added the triaged label Aug 13, 2020
@dagood dagood changed the title Re-enable sourcelink in source-build 5.0 Re-enable sourcelink in arcade-powered source-build (6.0) Feb 4, 2021
@dagood dagood mentioned this issue Feb 9, 2021
Closed
@MichaelSimons MichaelSimons changed the title Re-enable sourcelink in arcade-powered source-build (6.0) [ArPow] Re-enable sourcelink May 28, 2021
This was referenced Oct 26, 2021
Closed
Merged
@omajid
Copy link
Member

omajid commented Oct 17, 2022 •
edited
Loading

Sourcelink is enabled in .NET 6 and 7, which is why we discovered issues like #2903

IMO, we should close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crummel crummel

Labels
area-product-experience Improvements in the end-user's product experience area-upstream-fix Needs a change in a contributing repo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@omajid @crummel @MichaelSimons @dagood