Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using sourcelink to name the ArPow intermediate nupkgs using Git #2029

Closed
dagood opened this issue Feb 9, 2021 · 1 comment
Closed
Labels
area-infra Source-build infrastructure and reporting

Comments

@dagood
Copy link
Member

dagood commented Feb 9, 2021

Right now, eng/SourceBuild.props contains <GitHubRepositoryName>source-build</GitHubRepositoryName>. In theory, we could grab that from the git remote config through sourcelink.

But:

  • If this goes wrong, we end up publishing a package with a bad name to the feed. Still Microsoft.SourceBuild.Intermediate.<something>, so not untraceable, and not something that will break the world, but these are the stakes.
  • We would have to depend on some internal repo name -> public repo name translation, since they're different.
  • It would make it harder to repro locally if remotes aren't set up how sourcelink wants them.
  • Sourcelink doesn't work in arcade-powered source-build: When the "origin" remote points to a local directory that itself doesn't have an "origin" remote, SourceLink emits warning/error even though it has a fallback sourcelink#629 / [ArPow] Re-enable sourcelink #1693. I believe this only affects the inner build, not the outer build that actually assembles the intermediate nupkg, but I'd be a bit uneasy taking a dependency on that separation rather than fixing that issue.
  • How does this affect tarball builds that don't have remotes?
    • Will we actually produce intermediate nupkgs for tarball builds? (They help with incrementality.)

If that can be ironed out, it would be pretty easy to roll out an Arcade SDK update that makes GitHubRepositoryName obsolete, then remove the property in each repo. Since it's so easy to fix incrementally later on, and it's just one line of MSBuild code, it doesn't seem like a priority.

@dagood dagood added the area-infra Source-build infrastructure and reporting label Feb 9, 2021
@dagood
Copy link
Member Author

dagood commented Feb 18, 2021

Triage: this doesn't seem necessary for the initial ArPow plan and we are cutting it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infra Source-build infrastructure and reporting
Projects
None yet
Development

No branches or pull requests

1 participant