Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Microsoft.DotNet.Compatibility NuGet during source-build #2498

Closed
eerhardt opened this issue Oct 11, 2021 · 2 comments
Closed

Create Microsoft.DotNet.Compatibility NuGet during source-build #2498

eerhardt opened this issue Oct 11, 2021 · 2 comments
Assignees
Labels
area-additional-repos Adding additional contributing repos

Comments

@eerhardt
Copy link
Member

The Microsoft.DotNet.Compatibility NuGet package is a new package created in 6.0. The dotnet/runtime repo takes a dependency on this package during its build:

https://github.com/dotnet/runtime/blob/825b26409226be4a29c7dcbe5aab97b979e3dac0/eng/packaging.targets#L40-L42

However, this package isn't getting created during source-build. As far as I can tell, this is because we are using a .slnf file that doesn't include it:

https://github.com/dotnet/sdk/blob/599fde6a0276a1e9d8eefea4ee4e4a4f9518bfd8/source-build.slnf#L16

We should add the Microsoft.DotNet.Compatibility project to source-build, so the NuGet package gets created during source-build. That way the dotnet/runtime repo will pick up the source-built package and not use a pre-built version.

@MichaelSimons
Copy link
Member

This is blocked on these runtime changes flowing into installer - dotnet/runtime#60306. After they flow, we will need to update previous source-built and the prebuilt should be resolved.

@MichaelSimons
Copy link
Member

Added with dotnet/sdk#21978.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-additional-repos Adding additional contributing repos
Projects
None yet
Development

No branches or pull requests

3 participants