Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sdk patch to build Microsoft.DotNet.Compatilibity #12313

Closed

Conversation

MichaelSimons
Copy link
Member

Fixes dotnet/source-build#2498.

Updated previous source-built with a build containing this patch in order to eliminate the runtime prebuilt.

@@ -21,8 +21,8 @@
</PropertyGroup>
<!-- Production Dependencies -->
<PropertyGroup>
<PrivateSourceBuiltArtifactsPackageVersion>0.1.0-6.0.100-bootstrap.19</PrivateSourceBuiltArtifactsPackageVersion>
<PrivateSourceBuiltArtifactsPackageVersion>0.1.0-6.0.100-bootstrap.21</PrivateSourceBuiltArtifactsPackageVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my knowledge - why is this duplicated with eng/Versions.props?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that you ask, I am actively working on another issue to reduce the source built artifacts size and I don't think this is referenced. I will clean this up in that PR.

@MichaelSimons
Copy link
Member Author

Closing as the SDK changes have already flown into the installer repo.

@MichaelSimons MichaelSimons deleted the issue-2498 branch October 13, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants