-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put the final artifacts in the arcade well known output locations #4104
Comments
We should include a note in the source-build release announcement for this as it will impact distro-maintainers. |
1 task
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
ViktorHofer
added a commit
to dotnet/installer
that referenced
this issue
Feb 9, 2024
1. Shipping and non-shipping artifacts to Arcade default locations: -> artifacts/packages/<config>/Shipping -> artifacts/packages/<config>/NonShipping Add the local feed for the addition package directory to NuGet.config Remove the non-shipping packages list generation now that artifacts are grouped. 2. Genereated the intermediate PackageVersions* files in -> artifacts/obj/PackageVersions 3. Extract the repo symbol archives intermediates to -> artifacts/obj/Symbols/ 4. Sequence targets better and apply correct DependsOnTargets 5. Small clean-up Fixes dotnet/source-build#4104 Fixes dotnet/source-build#3696
github-project-automation
bot
moved this from In Progress
to Done
in .NET Unified Build
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The VMR currently puts some of the final artifacts under
artifacts/<arch>/<configuration>/...
. This includes the source-build tarball and other artifacts but none of the nuget packages (which are missing when not building from source).It would be good to change that to the Arcade convention which is
artifacts/packages/<configuration>/<Shipping|NonShipping>/
so that we can use the default Arcade templates for publishing artifacts to the pipeline and for publishing to BAR.As part of this, the README.md should also be updated.
The text was updated successfully, but these errors were encountered: