Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider updating pipeline to utilize build script args to specify target rid versus setting an msbuild property #4473

Closed
MichaelSimons opened this issue Jun 20, 2024 · 0 comments · Fixed by dotnet/sdk#42293
Closed

Consider updating pipeline to utilize build script args to specify target rid versus setting an msbuild property #4473

MichaelSimons opened this issue Jun 20, 2024 · 0 comments · Fixed by dotnet/sdk#42293
Labels
area-testing Improvements in CI and testing

Comments

@MichaelSimons
Copy link
Member

Recently build.sh support was added for users to specify the target rid. It would be beneficial to update the CI pipelines to utilize this functionality. Currently there are some legs that specify a custom rid via utilizing the appropriate msbuild property. Utilizing the build script would be beneficial as a way to add test coverage to ensure the build script front end remains functional.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Jun 20, 2024
@MichaelSimons MichaelSimons moved this from Backlog to 9.0 in .NET Source Build Jun 20, 2024
@MichaelSimons MichaelSimons added area-testing Improvements in CI and testing and removed area-build Improvements in source-build's own build process untriaged labels Jun 20, 2024
@MichaelSimons MichaelSimons moved this from 9.0 to 10.0 in .NET Source Build Jul 2, 2024
@Winniexu01 Winniexu01 mentioned this issue Jul 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from 10.0 to Done in .NET Source Build Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-testing Improvements in CI and testing
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Utilize build script args to specify target rid Winniexu01/sdk
1 participant
@MichaelSimons