-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --rid top level option #41540
Add --rid top level option #41540
Conversation
Other than my comment about preferring |
It would be nice to reduce the disparity in terminologies because this situation is confusing and not very self-explanatory:
|
All we really need is:
|
When we're adding top-level arguments to the vmr build script, I think we should name things so they are most clear to the package mantainers. They are supposed to figure out what to use without having to look at the implementation. |
Changed to $ dotnet build --help | grep IDENT
-r, --runtime <RUNTIME_IDENTIFIER> The target runtime to build for. |
I'm fine with calling it |
Windows aspnetcore failure is unrelated (failing on other PRs too). |
@am11, thank you for picking this up! |
Closes dotnet/source-build#4413
cc @tmds, @ViktorHofer