Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aspnetcore isn't building installers in the VMR #4692

Closed
ViktorHofer opened this issue Oct 23, 2024 · 2 comments · Fixed by dotnet/sdk#45437
Closed

aspnetcore isn't building installers in the VMR #4692

ViktorHofer opened this issue Oct 23, 2024 · 2 comments · Fixed by dotnet/sdk#45437
Assignees

Comments

@ViktorHofer
Copy link
Member

The BuildInstallers switch defines if installers should be built which defaults to false. We should pass the switch in here: https://github.com/dotnet/dotnet/blob/eb82b31516b032924126ac2c81f3edca80911619/repo-projects/aspnetcore.proj#L12

-buildinstallers (Unix) / - BuildInstallers (Windows)

Note that there's also a join point on Windows in the installers which will fail the Windows dev leg when it gets enabled: dotnet/aspnetcore#52884

cc @jkoritzinsky @NikolaMilosavljevic

@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Oct 23, 2024
@jkoritzinsky
Copy link
Member

I'm working on re-writing aspnetcore's installer infra to be based on the Arcade tooling as we speak. I'll take this on once I finish the rewrite.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Dec 2, 2024

The Windows part is now completed. @jkoritzinsky will continue working on the Unix part when he's back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants