-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runtime repo (portable and non-portable) and build in master #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dseefeld
force-pushed
the
addRuntimeRepo
branch
from
March 13, 2020 19:08
92a3bd1
to
02a189b
Compare
FYI @crummel @dagood @adaggarwal - this should be ready for review. |
dagood
reviewed
Apr 3, 2020
With the completion of dotnet#1497, the need to detect and remove these read only ref packages has been removed. All packages that we have identified as read-only in the past have been included in source-build-reference-packages. If any new ones show up, they will show up as prebuilts and can be added to the source-build-reference-packages repo.
This reverts commit 5766e7e.
adaggarwal
reviewed
Apr 6, 2020
…uild into addRuntimeRepo Conflicts: .vsts.pipelines/builds/matrix.yml
Going forward the repo will only be used for servicing.
adaggarwal
approved these changes
Apr 7, 2020
dagood
approved these changes
Apr 7, 2020
crummel
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Setting known-good to build through runtime - coreclr.