-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Preview4 and include Tier3 repos #1621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and capture clrtools from either portable or non-portable builds
…time since that's all previously-source-built supports.
crummel
approved these changes
Jul 2, 2020
dagood
reviewed
Jul 2, 2020
patches/arcade/0009-Add-reference-to-PlatformAbstractions.patch
Outdated
Show resolved
Hide resolved
patches/runtime/0012-Update-SDK-and-remove-RID-calculation-in-favor-of-Ru.patch
Show resolved
Hide resolved
dagood
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are about clarify, maybe the one about CopyTools
is the most important for future builds.
OSX failure issue logged here: #1641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update source-build to build 5.0-preview4 for current repos and add the Tier3 repos.
Fixes #1559