-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the new GitLab raw url #713
Conversation
Please review the TODOs and let me known how they should be handled. |
@rgl Sorry for the delay of my review. Was busy with other things. If you're still interested in finishing this PR please rebase and rerun tests and make sure all pass. We also need a new test that validates the usage of the Version metadata. |
BTW, is there some kind of release note from GitLab that announces the change in URL format? |
Doing a bit of history browsing, I came up with:
|
2b41d82
to
b6f2c4a
Compare
The url changed from, e.g.: https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs To: https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs See https://gitlab.com/gitlab-org/gitlab/-/issues/28848 See dotnet#670
b6f2c4a
to
7cb315c
Compare
@tmat, this is now ready for review. Please note that I'm assuming the URL change happened at GitLab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgl Looks great now. Thanks for the PR! |
…11) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) | `1.1.0` -> `1.1.1` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.SourceLink.GitHub/1.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.SourceLink.GitHub/1.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.SourceLink.GitHub/1.1.0/1.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.SourceLink.GitHub/1.1.0/1.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>dotnet/sourcelink (Microsoft.SourceLink.GitHub)</summary> ### [`v1.1.1`](https://github.com/dotnet/sourcelink/releases/tag/1.1.1) [Compare Source](https://github.com/dotnet/sourcelink/compare/1.1.0...1.1.1) #### Notable Changes - Feature: GitWeb Source Link provider by [@​Glen-Nicol-Garmin](https://github.com/Glen-Nicol-Garmin) in [dotnet/sourcelink#505 - Use submodule.name.url to determine the URL of a submodule by [@​tmat](https://github.com/tmat) in [dotnet/sourcelink#587 - Add Microsoft.SourceLink.Tools source package implementing SourceLinkMap by [@​tmat](https://github.com/tmat) in [dotnet/sourcelink#663 - Added support for gitea by [@​Mik4sa](https://github.com/Mik4sa) in [dotnet/sourcelink#674 - Enable source-build with Arcade SDK fixes by [@​dagood](https://github.com/dagood) in [dotnet/sourcelink#692 - Add netstandard2.0 target to tools package by [@​tmat](https://github.com/tmat) in [dotnet/sourcelink#702 - Update license to MIT by [@​tmat](https://github.com/tmat) in [dotnet/sourcelink#730 - Allow using .git directory instead of gitdir redirect in submodules. by [@​crummel](https://github.com/crummel) in [dotnet/sourcelink#653 - Fix discovery of working directory for worktrees by [@​tmat](https://github.com/tmat) in [dotnet/sourcelink#734 - Add support for the new GitLab raw url by [@​rgl](https://github.com/rgl) in [dotnet/sourcelink#713 - Target netcoreapp3.1 by [@​tmat](https://github.com/tmat) in [dotnet/sourcelink#767 #### New Contributors - [@​Glen-Nicol-Garmin](https://github.com/Glen-Nicol-Garmin) made their first contribution in [dotnet/sourcelink#505 - [@​IgorKustov-ChathamFinancial](https://github.com/IgorKustov-ChathamFinancial) made their first contribution in [dotnet/sourcelink#592 - [@​v-chmart](https://github.com/v-chmart) made their first contribution in [dotnet/sourcelink#604 - [@​0xced](https://github.com/0xced) made their first contribution in [dotnet/sourcelink#668 - [@​nycdotnet](https://github.com/nycdotnet) made their first contribution in [dotnet/sourcelink#672 - [@​Mik4sa](https://github.com/Mik4sa) made their first contribution in [dotnet/sourcelink#674 - [@​rgl](https://github.com/rgl) made their first contribution in [dotnet/sourcelink#713 - [@​adiaaida](https://github.com/adiaaida) made their first contribution in [dotnet/sourcelink#737 **Full Changelog**: dotnet/sourcelink@1.0.0...1.1.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apollographql/federation-hotchocolate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy44LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
In GitLab 13.5 (at least) the url changed from, e.g.:
https://gitlab.example.com/raw/example/example-dotnet-source-link/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs
To:
https://gitlab.example.com/example/example-dotnet-source-link/-/raw/538b7a2b0d086146a6534bfe6f98a379191ea529/ExampleApplication/Program.cs
This closes #670.