Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update M.D.A to 0.4.0 #528

Merged
merged 1 commit into from
May 21, 2020
Merged

Update M.D.A to 0.4.0 #528

merged 1 commit into from
May 21, 2020

Conversation

pgovind
Copy link
Contributor

@pgovind pgovind commented May 21, 2020 •
edited
Loading

Just updating the M.D.A dependency to 0.4.0

cc @eerhardt. Tagging @imback82 since I can't add you as a reviewer

eerhardt
eerhardt approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eerhardt eerhardt requested a review from imback82 May 21, 2020 18:02
imback82
imback82 approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @pgovind any notable new features/improvements/bug fixes from 0.4.0, so we can document in our next release notes? Thanks!

@imback82 imback82 merged commit ba609f5 into dotnet:master May 21, 2020
@imback82
Copy link
Contributor

@pgovind any notable new features/improvements/bug fixes from 0.4.0, so we can document in our next release notes? Thanks!

Gentle ping.

@pgovind
Copy link
Contributor Author

pgovind commented May 28, 2020

Oh, I didn't see this until now. 0.4.0 only has bug fixes. Primarily, it fixes bugs in the LoadCsv method: 1) We now correctly retain the column names from the csv file.
2) We've fixed a bug in the column DataType detection logic to handle null values

@imback82
Copy link
Contributor

Thanks @pgovind!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@imback82 imback82 imback82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgovind @imback82 @eerhardt