Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppName in examples to follow Spark naming convention #548

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

JavierLight
Copy link
Contributor

Fixes #544

Following rename structure suggested by imback82, I'm fixing AppName in those examples starting with an invalid character according to the Spark docs. This will allow running the examples using k8s as the resource manager. Using the previous AppNames the executor pods couldn't be created.

@dnfadmin
Copy link

dnfadmin commented Jun 15, 2020

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @JavierLight for your first contribution!

@imback82 imback82 merged commit 9240bfa into dotnet:master Jun 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example app name starts with an invalid character in k8s
4 participants