Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ML/CountVectorizer and ML/CountVectorizerModel #608

Merged
merged 23 commits into from
Sep 1, 2020
Merged

Implement ML/CountVectorizer and ML/CountVectorizerModel #608

merged 23 commits into from
Sep 1, 2020

Conversation

GoEddie
Copy link
Contributor

@GoEddie GoEddie commented Jul 31, 2020

This add support for Spark.ML.CountVectorizer and CountVectorizerModel for #381

@GoEddie GoEddie mentioned this pull request Jul 31, 2020
Open
39 tasks
@GoEddie GoEddie marked this pull request as ready for review July 31, 2020 19:53
Niharikadutta
Niharikadutta reviewed Aug 13, 2020
View reviewed changes
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerModelTests.cs Show resolved Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerModelTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerModelTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/ML/Feature/CountVectorizerModel.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/ML/Feature/CountVectorizerModel.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/ML/Feature/CountVectorizerModel.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/ML/Feature/CountVectorizerModel.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/ML/Feature/CountVectorizerModel.cs Outdated Show resolved Hide resolved
@GoEddie GoEddie marked this pull request as draft August 13, 2020 07:38
@GoEddie GoEddie marked this pull request as ready for review August 13, 2020 20:26
@Niharikadutta
Copy link
Collaborator

Few nit comments but otherwise LGTM. Thanks @GoEddie !

@GoEddie GoEddie marked this pull request as draft August 15, 2020 09:27
@GoEddie GoEddie marked this pull request as ready for review August 17, 2020 08:46
suhsteve
suhsteve previously approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. LGTM. Thanks @GoEddie !

src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerModelTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerTests.cs Outdated Show resolved Hide resolved
suhsteve
suhsteve previously approved these changes Aug 26, 2020
View reviewed changes
@Niharikadutta
Copy link
Collaborator

LGTM. Thanks @GoEddie !

Niharikadutta
Niharikadutta previously approved these changes Aug 28, 2020
View reviewed changes
@GoEddie
Copy link
Contributor Author

GoEddie commented Aug 28, 2020

Great thank you :)

@GoEddie GoEddie dismissed stale reviews from Niharikadutta and suhsteve via 9d59992 September 1, 2020 06:45
imback82
imback82 reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for nit comments.

src/csharp/Microsoft.Spark.E2ETest/IpcTests/ML/Feature/CountVectorizerTests.cs Outdated Show resolved Hide resolved
src/csharp/Microsoft.Spark/ML/Feature/CountVectorizerModel.cs Show resolved Hide resolved
imback82
imback82 approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @GoEddie!

@imback82 imback82 merged commit 9239e72 into dotnet:master Sep 1, 2020
@GoEddie GoEddie deleted the ml/countvectorizer branch September 2, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imback82 imback82 imback82 approved these changes

@Niharikadutta Niharikadutta Niharikadutta left review comments

@suhsteve suhsteve suhsteve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GoEddie @Niharikadutta @suhsteve @imback82