Increase Spark.Worker.UnitTest test coverage for different Spark versions #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimKiHyuk
force-pushed
the
tests/refactor-DaemonWorkerTests
branch
from
d6c4512
to
448c411
Compare
KimKiHyuk
changed the title
KimKiHyuk
changed the title
|
Looks like tests are failing? |
it seems to occur outofmemory exception when test case only 2.4.0, CI was passed. I think CI test machine memory is not enough to test all spark versions. |
|
Can you check which version is causing the failure? |
suhsteve
reviewed
Aug 22, 2020
It was my fault. The problem was a test logic and it has been resolved in cf191ea. thank you :) |
suhsteve
reviewed
Aug 24, 2020
| @@ -2,6 +2,8 @@ | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
| // See the LICENSE file in the project root for more information. | |||
|
|
|||
| using System; | |||
Comment on lines
17
to
25
| public static IEnumerable<object[]> versionTests() | ||
| { | ||
| yield return new object[] { Versions.V2_3_0 }; | ||
| yield return new object[] { Versions.V2_3_1 }; | ||
| yield return new object[] { Versions.V2_3_2 }; | ||
| yield return new object[] { Versions.V2_3_3 }; | ||
| yield return new object[] { Versions.V2_4_0 }; | ||
| yield return new object[] { Versions.V3_0_0 }; | ||
| } |
There was a problem hiding this comment.
nit
Suggested change
| public static IEnumerable<object[]> versionTests() | |
| { | |
| yield return new object[] { Versions.V2_3_0 }; | |
| yield return new object[] { Versions.V2_3_1 }; | |
| yield return new object[] { Versions.V2_3_2 }; | |
| yield return new object[] { Versions.V2_3_3 }; | |
| yield return new object[] { Versions.V2_4_0 }; | |
| yield return new object[] { Versions.V3_0_0 }; | |
| } | |
| public static IEnumerable<object[]> VersionData() => | |
| new List<object[]> | |
| { | |
| new object[] { Versions.V2_3_0 }, | |
| new object[] { Versions.V2_3_1 }, | |
| new object[] { Versions.V2_3_2 }, | |
| new object[] { Versions.V2_3_3 }, | |
| new object[] { Versions.V2_4_0 }, | |
| new object[] { Versions.V3_0_0 } | |
| }; |
imback82
approved these changes
Aug 26, 2020
imback82
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of spark versions but only 2.4.0 has been tested.
so I've added test cases, also move test cases to
TestData.csalso moved test cases have been reused in
PayloadProcessTests