Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureHasher #652

Merged
merged 29 commits into from
Oct 2, 2020
Merged

FeatureHasher #652

merged 29 commits into from
Oct 2, 2020

Conversation

GoEddie
Copy link
Contributor

@GoEddie GoEddie commented Sep 3, 2020

This implements FeatureHasher as part of #381 (Spark.ML)

@GoEddie GoEddie marked this pull request as draft September 3, 2020 22:10
@GoEddie GoEddie closed this Sep 3, 2020
@GoEddie GoEddie reopened this Sep 3, 2020
@GoEddie GoEddie marked this pull request as ready for review September 5, 2020 07:26
@imback82 imback82 added the enhancement New feature or request label Sep 8, 2020
@imback82 imback82 added this to the 1.0.0 milestone Sep 8, 2020
suhsteve
suhsteve previously approved these changes Sep 8, 2020
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but LGTM!

suhsteve
suhsteve previously approved these changes Sep 8, 2020
Niharikadutta
Niharikadutta previously approved these changes Sep 13, 2020
Copy link
Collaborator

@Niharikadutta Niharikadutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @GoEddie !

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few minor comments, but generally LGTM!

src/csharp/Microsoft.Spark/ML/Feature/FeatureHasher.cs Outdated Show resolved Hide resolved
/// </summary>
/// <returns>List of categorical columns, set by SetCategoricalCols</returns>
public IEnumerable<string> GetCategoricalCols() =>
((string[])_jvmObject.Invoke("getCategoricalCols")).ToList();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ToList required?

src/csharp/Microsoft.Spark/ML/Feature/FeatureHasher.cs Outdated Show resolved Hide resolved
Copy link
Member

@suhsteve suhsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @GoEddie!

@imback82 imback82 merged commit 422cbce into dotnet:master Oct 2, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants