PicklingUdfWrapper cache type information #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imback82
reviewed
Sep 25, 2020
imback82
reviewed
Sep 26, 2020
| @@ -35,16 +42,19 @@ internal object Execute(int splitIndex, object[] input, int[] argOffsets) | |||
| [UdfWrapper] | |||
| internal class PicklingUdfWrapper<T, TResult> | |||
| { | |||
| [NonSerialized] | |||
| private readonly bool?[] _sameT = new bool?[1]; | |||
There was a problem hiding this comment.
No need to create an array?
There was a problem hiding this comment.
all values in the array will have default values. The default value of a Nullable is null
There was a problem hiding this comment.
Oh I meant that this has only one element, so no need to create an array.
There was a problem hiding this comment.
ah got it. Changed it to use a non array for the 1 param case.
imback82
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache parameter type information to determine if converting/casting is necessary. This will help speed up the call if the Type only needs to be casted.
#683