Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Microsoft.Spark.Experimental to Microsoft.Spark #691

Merged
merged 8 commits into from
Sep 29, 2020
Merged

Move Microsoft.Spark.Experimental to Microsoft.Spark #691

merged 8 commits into from
Sep 29, 2020

Conversation

suhsteve
Copy link
Member

@suhsteve suhsteve commented Sep 25, 2020 •
edited by imback82
Loading

Moving experimental Microsoft.Data.Analysis.DataFrame support into Microsoft.Spark

Fixes #639.

@suhsteve suhsteve self-assigned this Sep 25, 2020
@suhsteve suhsteve added the enhancement New feature or request label Sep 25, 2020
@suhsteve suhsteve added this to the 1.0.0 milestone Sep 25, 2020
@suhsteve
Copy link
Member Author

Should we move the VectorUdf methods out of Functions and into it's own static class ArrowFunctions ?

@suhsteve
Copy link
Member Author

Should we move the VectorUdf methods out of Functions and into it's own static class ArrowFunctions ?

moved VectorUdf from Functions to ArrowFunctions

@imback82
Copy link
Contributor

@Niharikadutta Can you capture this change in the migration guide?

imback82
imback82 previously approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @suhsteve!

@Niharikadutta
Copy link
Collaborator

@Niharikadutta Can you capture this change in the migration guide?

Sorry, which migration guide?

@imback82
Copy link
Contributor

1.0 doc? I thought we were planning to have a migration section?

@Niharikadutta
Copy link
Collaborator

1.0 doc? I thought we were planning to have a migration section?

We haven't chalked out a specific 1.0 doc in #671 but we can discuss and talk about it to see what information it needs to contain.

@imback82
Copy link
Contributor

@suhsteve Can you check the following failure? Is this also random?

Microsoft.Spark.UnitTest.CallbackTests.TestCallbackServer
Assert.Equal() Failure
Expected: 10
Actual:   8

@suhsteve
Copy link
Member Author

@suhsteve Can you check the following failure? Is this also random?

Microsoft.Spark.UnitTest.CallbackTests.TestCallbackServer
Assert.Equal() Failure
Expected: 10
Actual:   8

This is related to our usage of threads. There's an issue tracking this. #685

@imback82
Copy link
Contributor

@Niharikadutta Can you add a migration guide section to #671, and have a bullet that links to this PR?

@Niharikadutta Niharikadutta mentioned this pull request Sep 28, 2020
Closed
30 tasks
Niharikadutta
Niharikadutta reviewed Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@Niharikadutta Niharikadutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @suhsteve !

@imback82 imback82 merged commit 6eee234 into dotnet:master Sep 29, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niharikadutta Niharikadutta Niharikadutta left review comments

@imback82 imback82 imback82 left review comments

@pgovind pgovind Awaiting requested review from pgovind

Assignees

@suhsteve suhsteve

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Move extensions in Microsoft.Spark.Experimental to Microsoft.Spark in 1.0
3 participants
@suhsteve @imback82 @Niharikadutta