Update version check logic on the worker #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhsteve
reviewed
Oct 8, 2020
| // is a breaking change on the UDF contract. | ||
| internal const string CurrentVersion = "0.9.0"; | ||
| // is a breaking change (major version change) on the UDF contract. | ||
| internal const string CurrentVersion = "1.0.0"; |
There was a problem hiding this comment.
Is this version going to be tightly coupled with the Microsoft.Spark assembly version? If so then can we just get the version of Microsoft.Spark loaded in the the current AppDomain ?
There was a problem hiding this comment.
Yes, good point. Now that we are going with semantic versioning, we don't need this. I will rework on this after #715 is in.
suhsteve
approved these changes
Oct 9, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 1.0.0, we enforce semantic versioning, meaning the worker will be compatible only within the same major version.
This PR changes the behavior of the version checking logic on the worker, following the semantic versioning.