Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs related to new Jar name #729

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Conversation

suhsteve
Copy link
Member

@suhsteve suhsteve commented Oct 9, 2020

Update docs related to new Jar name

Related to #728

Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one nit), thanks @suhsteve!

@@ -97,8 +97,9 @@ cd src\scala
mvn clean package
```
You should see JARs created for the supported Spark versions:
* `microsoft-spark-2.3.x\target\microsoft-spark-2.3.x-<version>.jar`
* `microsoft-spark-2.4.x\target\microsoft-spark-2.4.x-<version>.jar`
* `microsoft-spark-2-3/target/microsoft-spark-2-3_2.11-<version>.jar`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use \ since this is windows?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Updated

@imback82 imback82 merged commit 2a6479d into dotnet:master Oct 9, 2020
@suhsteve suhsteve deleted the update_doc_jar branch October 9, 2020 19:58
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants