Isolate all dotnet-interactive statements to use the same jvm thread #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhsteve
commented
Oct 12, 2020
src/csharp/Extensions/Microsoft.Spark.Extensions.DotNet.Interactive/AssemblyKernelExtension.cs
Show resolved
Hide resolved
AFFogarty
reviewed
Oct 12, 2020
imback82
reviewed
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each code submission processed by
dotnet-interactiverun on an available thread in its thread pool. This means that if two separate code submissions were submitted, each may run on a different thread in the CLR, which in turn be processed on a different thread in the JVM.This PR prevents this from occurring by forcing the same JVM thread to process all incoming requests from the CLR when running a
dotnet-interactiverepl session.