Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate deserialization of localization files during install and instantiate #3132

Closed
3 tasks done
Tracked by #2798
bekir-ozturk opened this issue May 5, 2021 · 0 comments · Fixed by #3216
Closed
3 tasks done
Tracked by #2798

Validate deserialization of localization files during install and instantiate #3132

bekir-ozturk opened this issue May 5, 2021 · 0 comments · Fixed by #3216
Assignees
@bekir-ozturk
Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Milestone
May'21

Comments

@bekir-ozturk
Copy link
Contributor

bekir-ozturk commented May 5, 2021 •
edited by vlada-shubina
Loading

Follow up task to #3133

  • Add a validation step right after localization deserialization and print errors if validation fails.
  • Make sure that an error is printed to the screen when user is installing/instantiating a template with broken localization files using CLI.
  • Make sure that no error is displayed when user is installing/instantiating a template with valid localization files using CLI.
@bekir-ozturk bekir-ozturk added this to the May Sprint milestone May 5, 2021
@bekir-ozturk bekir-ozturk added the triaged The issue was evaluated by the triage team, placed on correct area, next action defined. label May 5, 2021
@bekir-ozturk bekir-ozturk mentioned this issue May 24, 2021
Closed
7 tasks
@bekir-ozturk bekir-ozturk changed the title Add tests for validation of localization files during install and instantiate Validate deserialization of localization files during install and instantiate May 24, 2021
@bekir-ozturk bekir-ozturk self-assigned this May 24, 2021
This was referenced May 25, 2021
Merged
Merged
Merged
@vlada-shubina vlada-shubina mentioned this issue Sep 3, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bekir-ozturk bekir-ozturk

Labels
triaged The issue was evaluated by the triage team, placed on correct area, next action defined.
Projects
None yet
Milestone
May'21
Development

Successfully merging a pull request may close this issue.

Localization model validation dotnet/templating
1 participant
@bekir-ozturk