Localization model validation #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/SimpleConfigModel.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizationModelDeserializer.cs
Outdated
Show resolved
Hide resolved
vlada-shubina
force-pushed
the
dev/bozturk/loc-validation-during-load
branch
from
c33a01c to
7b39dff
Compare
bekir-ozturk
force-pushed
the
dev/bozturk/loc-validation-during-load
branch
from
7b39dff to
acfe7ea
Compare
vlada-shubina
force-pushed
the
dev/bozturk/loc-validation-during-load
branch
2 times, most recently
from
03f7264 to
449274b
Compare
vlada-shubina
force-pushed
the
dev/bozturk/loc-validation-during-load
branch
from
449274b to
3ae29c7
Compare
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ISymbolModel.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/ISymbolModel.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/SimpleConfigModel.cs
Show resolved
Hide resolved
bekir-ozturk
commented
Jun 7, 2021
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizableStrings.resx
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizableStrings.resx
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizableStrings.resx
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizableStrings.resx
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizableStrings.resx
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/SimpleConfigModel.cs
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/SimpleConfigModel.cs
Show resolved
Hide resolved
...plateEngine.Orchestrator.RunnableProjects.UnitTests/TemplateConfigTests/LocalizationTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/IFileSystemInfoExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/LocalizationModelDeserializer.cs
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/RunnableProjectGenerator.cs
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/RunnableProjectGenerator.cs
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/RunnableProjectGenerator.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/RunnableProjectGenerator.cs
Show resolved
Hide resolved
vlada-shubina
approved these changes
Jun 9, 2021
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/IFileSystemInfoExtensions.cs
Show resolved
Hide resolved
# Conflicts: # src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/RunnableProjectGenerator.cs # src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/SimpleConfigModel.cs
bekir-ozturk
force-pushed
the
dev/bozturk/loc-validation-during-load
branch
from
0b302c3 to
c1374e3
Compare
DavidKarlas
approved these changes
Jun 9, 2021
src/Microsoft.TemplateEngine.Orchestrator.RunnableProjects/IFileSystemInfoExtensions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #3132.
Solution
Adding checks to evaluate the validity of template localization model.
Checks:
#nullable enableto all the modified files ?