Mapping "binding.ContainerPort" instead of "binding.Port" to "manifes…

…t containerPort"
dotnet · Nov 2, 2020 · 814e9e6 · 814e9e6
1 parent b068e39
commit 814e9e6
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/Microsoft.Tye.Core/KubernetesManifestGenerator.cs b/src/Microsoft.Tye.Core/KubernetesManifestGenerator.cs
@@ -183,7 +183,11 @@ public static KubernetesServiceOutput CreateService(
                     port.Add("name", binding.Name ?? binding.Protocol ?? "http");
                     port.Add("protocol", "TCP"); // we use assume TCP. YOLO
                     port.Add("port", binding.Port.Value.ToString());
-                    port.Add("targetPort", binding.Port.Value.ToString());
+
+                    // this ?
+                    port.Add("targetPort", (binding.ContainerPort ?? binding.Port.Value).ToString());
+                    // or this ?
+                    // port.Add("targetPort", (binding.ContainerPort ?? 80).ToString());
                 }
             }
 
@@ -374,8 +378,13 @@ public static KubernetesDeploymentOutput CreateDeployment(
                         {
                             var containerPort = new YamlMappingNode();
                             ports.Add(containerPort);
-                            containerPort.Add("containerPort", binding.Port.Value.ToString());
+
+                            // this ?
+                            containerPort.Add("containerPort", (binding.ContainerPort ?? binding.Port.Value).ToString());
+                            // or this ?
+                            //containerPort.Add("containerPort", (binding.ContainerPort ?? 80).ToString());
                         }
+
                     }
                 }