-
Notifications
You must be signed in to change notification settings - Fork 520
Conversation
I ran these tests in a clean Fedora 33 VM. I did the following configuration: mkdir -p $HOME/.config/containers
cat >$HOME/.config/containers/containers.conf <<EOF
[engine]
network_cmd_options=["allow_host_loopback=true"]
EOF
sudo dnf -y update podman Then ran: ./build.sh --test All tests passed. For E2E:
|
@jkotalik can you review the PR? Functionally I think it's fine, but you may want to suggest some refactorings. I hope this can be part of the next tye release. |
LGTM besides an option to turn on and off. |
@jkotalik I've added an option to |
src/schema/tye-schema.json
Outdated
@@ -13,6 +13,11 @@ | |||
"description": "Dockerhub username or hostname of remote registry. Used for tagging images.", | |||
"type": "string" | |||
}, | |||
"engine": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think containerEngine is a better name here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending a rename.
I've renamed the property. I also relaxed the podman version check because I don't want risk it making things unusable. Instead of failing when we can't parse the version, we assume the version requirement is met. |
Thanks! |
@jkotalik thank you too. Do you have a rough idea when you'll do the next release? |
Hoping for one relatively soon 👍 . There are a few key bugs we need to fix first (.NET 6 support). |
This makes tye work with rootless podman.
It requires podman 3.1+.
Users need to update their
$HOME/.config/containers/containers.conf
to allow containers to access services on the host:All tests pass except
NginxIngressTest
which fails for me due to #428.Fixes #563
@davidfowl @jkotalik ptal