This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
DockerRunner: include stderr in log on failure. #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmds
requested review from
davidfowl,
jkotalik,
JunTaoLuo and
rynowak
as code owners
tmds
commented
May 25, 2021
| // Even though the Exited event has been raised, WaitForExit() must still be called to ensure the output buffers | ||
| // have been flushed before the process is considered completely done. | ||
| process.WaitForExit(); | ||
| lock (process) |
There was a problem hiding this comment.
I noticed this potential race so I added a lock for it.
tmds
commented
May 25, 2021
| var result = await application.ContainerEngine.RunAsync( | ||
| command, | ||
| throwOnError: false, | ||
| cancellationToken: cancellationToken, | ||
| outputDataReceived: data => service.Logs.OnNext($"[{replica}]: {data}"), | ||
| errorDataReceived: data => service.Logs.OnNext($"[{replica}]: {data}")); | ||
| errorDataReceived: data => { service.Logs.OnNext($"[{replica}]: {data}"); stderr.AppendLine(data); }); |
jkotalik
approved these changes
May 25, 2021
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jkotalik ptal