This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Add dockerfile build args documentation #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danspark
requested review from
davidfowl,
jkotalik,
JunTaoLuo and
rynowak
as code owners
|
@danspark Thanks for the contribution. Would you mind also adding the property to the JSON schema? |
Done!
|
philliphoff
reviewed
Jun 25, 2021
philliphoff
approved these changes
Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to dig a little bit to find out if it was possible to pass build arguments on a
tye.yamlfile. Turns out it is possible, it was made on #521, but I didn't find any docs explaining how. I just added a new section to theschema.md, let me know if there's anything I can add to make it more clear.