This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tye currently assumes that all Dapr-ized services are intended to be invoked by other services (or by the Dapr runtime itself, in terms of receiving messages from subscriptions). This implies that all Dapr-ized services have an HTTP binding (in order to be reachable by the Dapr runtime). If a service has no HTTP bindings, no Dapr runtime will be started for that service.
However, not all services require that; some may only make outbound calls to other services, directly or via pub-sub (e.g. subscribe to and receive message from an alternative source, process them, then invoke another service via Dapr). In this case, while the Dapr runtime is still needed but the application may not expose an HTTP endpoint (i.e. intended for Dapr as it has no need). The Dapr runtime supports this scenario, by omitting the
--app-port
parameter on startup.This change allows more nuance in the Dapr extension. The default behavior remains that, if a service has an HTTP binding, a Dapr runtime will be started for it, using that bound port. Otherwise, it will not. However, the developer can now override that behavior using a new per-service configuration setting. In addition, if a service has only a single binding, and that binding has no explicit protocol, it will be assumed to be HTTP for the purposes of Dapr-ization.
Resolves #1172
Resolves #1178