Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Added support for additional routes on the Dashboard #1200

Merged
merged 5 commits into from
Jan 20, 2022

Conversation

ante-maric
Copy link
Contributor

This PR covers issue #618 for supporting additional routes on the Dashboard in Bindings column. This makes it easier to navigate to endpoints that you access frequently like /swagger.

@dnfadmin
Copy link

dnfadmin commented Oct 15, 2021

CLA assistant check
All CLA requirements met.

@ante-maric
Copy link
Contributor Author

Is there anything I can help with to get this going?

@davidfowl
Copy link
Member

Some design feedback: Routes should be an array instead of a semicolon delimited String

@ante-maric
Copy link
Contributor Author

Some design feedback: Routes should be an array instead of a semicolon delimited String

Thanks for the feedback, I have applied the requested changes.

@digitaldias
Copy link

Any traction on this? Looking like it's closer now :)

@philliphoff
Copy link
Contributor

@ante-maric Looks good to me, and rather handy! Thanks for the submission! The only change I've made is to use blocks for the binding spans, as it starts to get hard to read with many routes.

@ravipal Since I've made changes myself, can you review as well?

@philliphoff philliphoff merged commit cad496f into dotnet:main Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants