Move Tye to .NET 6 #1215
Move Tye to .NET 6 #1215
Conversation
There was a problem hiding this comment.
Should this https://github.com/dotnet/tye/blob/main/docs/getting_started.md be updated as well?
| var majorString = element.Value.GetProperty("major").GetString(); | ||
| var minorString = element.Value.GetProperty("minor").GetString(); | ||
|
|
||
| if (majorString != null && minorString != null) |
There was a problem hiding this comment.
will element.Value.GetProperty("major").GetString() ever return null?
There was a problem hiding this comment.
GetProperty() will return null if the property doesn't exist, which is unlikely, but could conceivably happen.
There was a problem hiding this comment.
I think it throws error instead of returning null. Even if it returns null, the .GetString() will result into null ref exception.
There was a problem hiding this comment.
Ah, yes, sorry, my mistake. It's GetString() which could return null (if the property exists but is set to null).
Yes, thanks for thinking of that. I made a quick pass through the docs and updated outdated references to .NET Core. |
|
Too late, but this is missing: In order for Tye to work on a Mac that has both the arm64 and x64 SDKs you need to supply the Example: |
Moves the Tye CLI and related components (like the container proxy) to .NET 6. Updates test asset projects to .NET 6 as well. These changes mean development machines must have .NET 6 installed in order to use Tye in addition to the .NET SDK/runtime used by the projects built/started by Tye. For example, if your application still targets .NET Core 3.1, you will need to have both the .NET 6 runtime and the .NET Core 3.1 SDK/runtime installed.
Existing .NET Standard libraries (e.g. the configuration library) will continue to target .NET Standard.
Related to #1213
Resolves #1216