This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Include service args in the docker file generator #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
|
|
I threw in a test to make sure the docker file still builds with args in there. |
davidfowl
reviewed
Jan 4, 2023
|
|
||
| [ConditionalFact] | ||
| [SkipIfDockerNotRunning] | ||
| public async Task ProjectWithArgsBuildTest() |
There was a problem hiding this comment.
How does this test asset the arguments are being passed and working?
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the project args from the tye.yaml file when building the docker file for kubernetes deployments.
This addresses:
#869