This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Add debug and tracing annotations #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Apr 4, 2020
rynowak
reviewed
Apr 4, 2020
rynowak
reviewed
Apr 4, 2020
rynowak
suggested changes
Apr 4, 2020
removed redundant code
davidfowl
reviewed
Apr 8, 2020
| @@ -138,15 +138,17 @@ public override Task ProcessAsync(ExtensionContext context, ExtensionConfigurati | |||
| deployment.Annotations.Add("dapr.io/id", project.Name); | |||
| deployment.Annotations.Add("dapr.io/port", (httpBinding.Port ?? 80).ToString(CultureInfo.InvariantCulture)); | |||
|
|
|||
| #pragma warning disable CS8604 // Possible null reference argument. | |||
There was a problem hiding this comment.
That's usally done by doing this:
daprConfig!.ToString()
There was a problem hiding this comment.
I did it with your suggestion, but no luck. Could anyone tell me how can I overcome this check?
There was a problem hiding this comment.
I did deployment.Annotations.TryAdd("dapr.io/config", daprConfig!.ToString() ?? string.Empty);, and it can overcome this check but not sure it is correctly
|
I'll clone this and take a look. let's try to get this done 👍 |
|
This looks close enough and you've got the basics done. I'm going to merge this and then I'll fix the formatting. |
rynowak
approved these changes
Apr 16, 2020
kishanAnem
pushed a commit
to kishanAnem/tye
that referenced
this pull request
Apr 19, 2020
* add debug and tracing annotations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
dapr.io/configanddapr.io/log-levelinto the annotations section in dapr.yaml. Related to #296