This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Support dapr log level and config for local run #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #296 Adds conditional logic for passing these properties to `daprd`. Corrects logic for dealing with config. Dapr's config annotation in k8s refers to kubernetes resource by name, but that's not possible with local run. In local run `dapr` will expect the `-config` parameter to be a file on disk. So, this change adds logic to look for a file by naming convention and pass that locally instead. Additionally added the ability for an extension to output to the console - this is needed because we want to tell the user if their config file can't be found, and specifically where we looked. I made the decision to log a message and skip if the config file isn't present, because we don't have a way to make settings conditional based on environment yet - it makes sense that someone might need to have a config in production but not in local dev.
rynowak
commented
Apr 17, 2020
davidfowl
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
Adds conditional logic for passing these properties to
daprd.Corrects logic for dealing with config. Dapr's config annotation in k8s
refers to kubernetes resource by name, but that's not possible with
local run. In local run
daprwill expect the-configparameter to bea file on disk. So, this change adds logic to look for a file by naming
convention and pass that locally instead.
Additionally added the ability for an extension to output to the console
can't be found, and specifically where we looked. I made the decision to
log a message and skip if the config file isn't present, because we
don't have a way to make settings conditional based on environment yet -
it makes sense that someone might need to have a config in production
but not in local dev.