This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
angular dotnet core sample for project tye #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulsahay19
requested review from
davidfowl,
jkotalik and
rynowak
as code owners
|
|
jkotalik
reviewed
May 15, 2020
davidfowl
reviewed
May 16, 2020
| services: | ||
| - name: moviesapi | ||
| project: MoviesAPI/MoviesAPI.csproj | ||
| bindings: |
There was a problem hiding this comment.
Hi, Do you want me to remove the port? I kept it because angular service will be calling that API on that particular port? angular app port can be removed as its not getting called from any app
There was a problem hiding this comment.
@davidfowl Hi,
You were saying sometime back that you wanted to simplify this further your way. Then, maybe you can merge this and do the required changes on top of it. Otherwise, you can pass on the instructions what you wanted to do. I will accommodate that. Because I don't understand "Remove the port?" thing. If I remove it from .net app, then angular app will fail as it won't be able to discover the port what api is exposing.
Thanks,
Rahul
davidfowl
reviewed
May 16, 2020
| dockerFile: MoviesApp/Dockerfile | ||
| bindings: | ||
| - protocol: http | ||
| port: 4400 |
davidfowl
approved these changes
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidfowl
Hi,
As discussed I have created a PR for your review. I have also added a Readme file explaining setup part.
Thanks,
Rahul Sahay