This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
log verbosity in tye run #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
May 27, 2020
| Verbosity.Quiet => LogEventLevel.Warning, | ||
| Verbosity.Info => LogEventLevel.Information, | ||
| Verbosity.Debug => LogEventLevel.Verbose, | ||
| _ => default |
There was a problem hiding this comment.
You mean _ => default?
This is to appease the C# compiler :)
It throws a warning otherwise
There was a problem hiding this comment.
I’m asking why use default and not an end value like Verbose or Info for the default case
There was a problem hiding this comment.
That _ => default should never happen. It's just an artifact of the compiler treating the enum as an integer. There is already a place where we set the default value for the verbosity, so I didn't want to repeat that in multiple places.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We allow the user to specify the level of output verbosity when running
tye runThe levels are