Skip to content
This repository has been archived by the owner on Nov 20, 2023. It is now read-only.

Fix static file loading when using ingress with host #591

Merged
merged 6 commits into from
Jul 17, 2020

Conversation

areller
Copy link
Contributor

@areller areller commented Jul 16, 2020

I've encountered a problem when using an ingress host rule to route to UI applications.

Example:

- host: ui.example.com
  service: appC-ui

The problem was that static files (.css, .js, etc..) wouldn't load

Turns out that MapFallback doesn't route to static files.

@jkotalik
Copy link
Contributor

Looks like some tests are still failing.

@areller
Copy link
Contributor Author

areller commented Jul 16, 2020

@jkotalik looks like it's complaining about the new project in testassets, probably because it targets net5.0
I'll downgrade

@jkotalik
Copy link
Contributor

Yeah, we were planning on adding 5.0 support this release, but we hit some major roadblocks that we need to investigate with regards to msbuild loading.

@davidfowl davidfowl merged commit 5ea1ae0 into dotnet:master Jul 17, 2020
@areller areller deleted the fix-ingress-static-files branch July 17, 2020 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants