This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Graceful termination in Windows #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any thoughts about this one? @davidfowl @jkotalik |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, Tye would
CloseMainWindowbut that didn't have any effect becauseCreateNoWindowwas set totruein theProcessStartInfo.Now, when in Windows, I run the process with an invisible window and when I call
CloseMainWindow, I wait 5 seconds for the process to exit gracefully (just like in Unix), before it's forcefully killed.If
CloseMainWindowfails (host can run from an environment where spawning windows is not possible), I default to killing the process (just like it has behaved before for Windows).This solves a problem that I was having, I had an executable (parent) that launched another executable (child) and when Tye killed the parent, it would the child hanging.