This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Docker compose environment variable syntax #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
areller
requested review from
davidfowl,
jkotalik and
rynowak
as code owners
|
@jkotalik @davidfowl @JunTaoLuo any thoughts about this? |
|
I like it! We used to have this but then we had the idea of config sources and changed the syntax. |
davidfowl
reviewed
Oct 2, 2020
| var value = nodeValue.Substring(keyValueSeparator + 1)?.Trim(); | ||
|
|
||
| config.Name = key; | ||
| config.Value = value?.Trim(new[] { ' ', '"' }) ?? string.Empty; |
There was a problem hiding this comment.
Do we have tests for this case?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses this issue #657
envfield in a service now accepts string of environment variables where the key and value are separated by a=sign.envis either missing avaluekey or is a string that misses a=sign, the value of the environment variable is taken from the operating system/shell.env_filewhich is a collection of strings which represent file paths. These file paths are formatted as explained in https://docs.docker.com/compose/env-file/