This repository has been archived by the owner on Nov 20, 2023. It is now read-only.
Refactored ConfigFileFinder.cs #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirh3e
requested review from
davidfowl,
jkotalik,
JunTaoLuo and
rynowak
as code owners
jkotalik
approved these changes
Nov 17, 2020
| return false; | ||
| } | ||
| if (files.Length <= 1) | ||
| continue; |
|
Added braces |
|
There is something wrong with the build pipeline. The Build Windows task timed out on this PR as well. (This happened with with #767 too). |
JunTaoLuo
reviewed
Nov 20, 2020
| @@ -23,12 +23,14 @@ public static bool TryFindSupportedFile(string directoryPath, out string? filePa | |||
| return true; | |||
| } | |||
|
|
|||
| if (files.Length > 1) | |||
| if (files.Length <= 1) | |||
There was a problem hiding this comment.
Isn't this condition only applicable when the length is 0? If so let's just make it if (files.Length == 0)
JunTaoLuo
approved these changes
Nov 20, 2020
|
@JunTaoLuo Yeah, you're right. It was late when I made the change. 😄 |
jkotalik
pushed a commit
that referenced
this pull request
Dec 1, 2020
* removed one intend * changed 0 <= into == 0 because it can not be less then zero see also #786 for more informations * added newline looks nicer * removed intend if * use of initalizes * check for not null * removed if nesteding * check for null * check for null * remove if nesting * added initializer * use of language feature destruction key value * removed unused () brakes * use of switch statment instend of if
jkotalik
reviewed
Dec 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.