-
Notifications
You must be signed in to change notification settings - Fork 520
#965 change dapr startup from daprd to dapr CLI #966
Conversation
I've been chatting with @mmisztal1980 - about this one. We launch dapr sidecars using |
@@ -271,23 +271,23 @@ private string GetDaprExecutablePath() | |||
// Starting with dapr version 11, dapr is installed in user profile/home. | |||
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows)) | |||
{ | |||
var windowsPath = Environment.ExpandEnvironmentVariables("%USERPROFILE%/.dapr/bin/daprd.exe"); | |||
var windowsPath = Environment.ExpandEnvironmentVariables("%HOMEDRIVE%/dapr/dapr.exe"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rynowak is there any plan to move dapr.exe outside of the %HOMEDRIVE%?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think not since it's 1.0.
Thanks! |
@jkotalik any chance this change is available in the upcoming nightly build? |
Yeah it will be available shortly. https://github.com/dotnet/tye/blob/master/docs/getting_started.md#working-with-ci-builds |
@jkotalik I've updated the tool, which resolved to: Did the nightly build emit the artifact successfully? I can see that my change was built: https://dnceng.visualstudio.com/public/_build/results?buildId=1030021&view=results however the build number |
What happens when you run tye --version? |
@jkotalik here you go tye --version
0.7.0-alpha.21153.4+528c743efc48eb0c5aa18c9272fac5235f38b0ed |
Hm, for some reason your change didn't make it to a public build. I'll look into it. |
In the mean time, you can also build from source: https://github.com/dotnet/tye/blob/master/docs/developer_guide.md#using-local-builds |
@mmisztal1980 it's available now. |
@jkotalik fooling around with the locally-built version, trying to run one of the samples (pub-sub) to verify that the change is working, however the services are in a crash-loop. I've stopped and removed all containers prior to executing The dapr dashboard remains empty at this time - my guess it due to the issue I'm experiencing docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
92d121b89e6d mcr.microsoft.com/dotnet/core/sdk:3.1 "dotnet Microsoft.Ty…" 55 seconds ago Up 51 seconds orders-proxy_dadf5689-e
b566fe6baf73 mcr.microsoft.com/dotnet/core/sdk:3.1 "dotnet Microsoft.Ty…" 55 seconds ago Up 51 seconds products-proxy_7835b9ca-f
4c667c5b6d03 mcr.microsoft.com/dotnet/core/sdk:3.1 "dotnet Microsoft.Ty…" 55 seconds ago Up 50 seconds store-dapr-proxy_63c77d5a-9
8138b12d2ab6 mcr.microsoft.com/dotnet/core/sdk:3.1 "dotnet Microsoft.Ty…" 55 seconds ago Up 51 seconds products-dapr-proxy_ce5a0d76-7
e2ccb3d95224 daprio/dapr "./placement" 55 seconds ago Up 51 seconds 0.0.0.0:51380->50005/tcp placement_4694fb85-c
da5e227d3686 mcr.microsoft.com/dotnet/core/sdk:3.1 "dotnet Microsoft.Ty…" 55 seconds ago Up 52 seconds orders-dapr-proxy_daedc872-f
edb335a0c96d mcr.microsoft.com/dotnet/core/sdk:3.1 "dotnet Microsoft.Ty…" 55 seconds ago Up 52 seconds store-proxy_a069375b-f
fa899117260d redis "docker-entrypoint.s…" 55 seconds ago Up 52 seconds 0.0.0.0:6379->6379/tcp redis_a3b4f8ca-9 |
found something, working on it |
I've managed to fix the crash-loop, the @rynowak any hints?
|
This PR:
daprd
startup with dapr CLI in order to have thedapr dashboard
detect dapr services started with Tye as described in Dapr dashboard does not detect dapr services started with Tye #965