Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help users file issues using the clipboard #2845

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

akshita31
Copy link
Contributor

@akshita31 akshita31 commented Feb 8, 2019

Fixes : #2754

  1. Updates to use the 1.31.0 version of vscode.
  2. Update to node 10
  3. Remove the dependency on "open" as it contained a critical vulnerability
  4. Use the clipboard api and paste the issue information to the clipboard and open the issue with the text - "Please paste the output from your clipboard"

@akshita31 akshita31 requested review from gregg-miskelly and rchande and removed request for gregg-miskelly February 8, 2019 02:54
@akshita31
Copy link
Contributor Author

Once this change is merged we can also merge : #2753, so that users can file issues properly with all the relevant information.

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #2845 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2845      +/-   ##
==========================================
+ Coverage   87.17%   87.18%   +<.01%     
==========================================
  Files          59       59              
  Lines        1739     1740       +1     
  Branches      206      206              
==========================================
+ Hits         1516     1517       +1     
  Misses        168      168              
  Partials       55       55
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 87.18% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/features/reportIssue.ts 79.48% <100%> (+0.53%) ⬆️
src/observers/OpenURLObserver.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8257f7f...46dec6d. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #2845 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2845   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          59       59           
  Lines        1570     1570           
  Branches       89       89           
=======================================
  Hits         1409     1409           
  Misses        149      149           
  Partials       12       12
Flag Coverage Δ
#integration 100% <ø> (ø) ⬆️
#unit 89.74% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/features/reportIssue.ts 83.87% <100%> (ø) ⬆️
src/observers/OpenURLObserver.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de1b39...8dfdd7f. Read the comment docs.

@akshita31 akshita31 force-pushed the vscode_clipboard branch 6 times, most recently from 61e8eab to c2ea932 Compare February 11, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants