Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debugger Packages and add Linux ARM/ARM64 Packages #4091

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

WardenGnaw
Copy link
Contributor

@WardenGnaw WardenGnaw commented Sep 28, 2020

This PR updates to the newest version of the debugger.

Along with this, this PR adds linux ARM and ARM64 packages to package.json.
It also updates platform to check for Linux architecture that have armv
and aarch in the uname -m output then set them as arm or arm64.

Also adds a couple of TODO's once the C# Omnisharp extension is ready to
run on the VS Code ARM/ARM64 builds.

See microsoft/vscode#106289

@WardenGnaw WardenGnaw self-assigned this Sep 28, 2020
src/main.ts Outdated Show resolved Hide resolved
@WardenGnaw
Copy link
Contributor Author

@gregg-miskelly Since we are enabling local debugging for ARM/ARM64, do we want to remove this remote extension error hint?

https://github.com/OmniSharp/omnisharp-vscode/blob/1ab9c4ca09291033ff71716330df9e3032aec79f/src/main.ts#L132-L142

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@2d26b5d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4091   +/-   ##
=========================================
  Coverage          ?   85.99%           
=========================================
  Files             ?       60           
  Lines             ?     1856           
  Branches          ?      214           
=========================================
  Hits              ?     1596           
  Misses            ?      200           
  Partials          ?       60           
Flag Coverage Δ
#integration 100.00% <ø> (?)
#unit 85.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d26b5d...67fc5fe. Read the comment docs.

Also added ARM and ARM64
@WardenGnaw WardenGnaw force-pushed the dev/waan/debuggerARMPackages branch from 6409772 to 67fc5fe Compare October 6, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants