Support inlay hints

[333fred]

Closes OmniSharp/omnisharp-roslyn#1932. Implements the new inlay hint api for vscode, now that it's stable and in LSP. Tests still need to be written.

[333fred]

This will need OmniSharp/omnisharp-roslyn#2357 to be merged, and I still need to write some integration tests covering the new feature. Some screenshots:

[somedeveloperhappy]

I just wanted to come here and thank you guys for all your efforts. the inlay hints was one of the main reasons I still have Rider installed on my machine

[JoeRobich]

Did you test this with a Razor scenario?

Do we need to filter out Razor generated documents?
https://github.com/OmniSharp/omnisharp-vscode/blob/84f1d5ab16718c2e0ad91e732770515500a8113e/src/features/virtualDocumentTracker.ts#L25-L39

Or handle mapping location information to Razor documents by passing it through the LanguageMiddleware?
https://github.com/OmniSharp/omnisharp-vscode/blob/84f1d5ab16718c2e0ad91e732770515500a8113e/src/features/referenceProvider.ts#L25-L27

[333fred]

I think we should probably avoid razor documents for now, until @NTaylorMullen has a chance to test it out and make sure that everything is working as expected.

[JoeRobich]

Suggestion on how to make the test more consistent

[somedeveloperhappy]

hey. I really need this feature even if it's in beta. can someone help me on how to use this branch in vscode? I could be helpful with my bug reports later :p

[333fred]

@JoeRobich we'll see, but locally the test doesn't even require that the file is open at all. Something else is happening.

[333fred]

hey. I really need this feature even if it's in beta. can someone help me on how to use this branch in vscode? I could be helpful with my bug reports later :p

Check out the branch and build it.

[somedeveloperhappy]

hey. I really need this feature even if it's in beta. can someone help me on how to use this branch in vscode? I could be helpful with my bug reports later :p

Check out the branch and build it.

yes, trying. but my npm gives out too many errors :(
is there some magic command that installs all needed npm packages?

• also if you don't have time, I'll still be very glad if you at least tell me what to search/google about that

Nevermind. I successfully built the package and tested it and THANKS! I wish I could somehow support you guys because this feature made me completely delete Rider and switch to vscode for good :)

[somedeveloperhappy]

Hey, umm , this is written "Merged" does it mean It's officially gonna go to the master branch now? Or just to the master of this fork?

Sorry I don't know much about GitHub

[333fred]

This isn't a fork, it's the main repository. And yes, it has been merged to master and will be in the next release of omnisharp vscode.

[somedeveloperhappy]

Thanks, yeah, figured that out by some research afterwards :D thanks. And the feature is really great! You guys are breaking the boundaries between vscode and Rider for dotnet!

• Though the new omnisharp loads suggestions after maybe a whole 1 second :( I'm assuming it's got something to do with the omnisharp itself and not the inlay hints, but just wanted to let you know

[JoeRobich]

@somedeveloperhappy Do you have either of these options enabled? Async completion should help with completion performance.

    "omnisharp.enableAsyncCompletion": true,
    "omnisharp.enableImportCompletion": true,