Add a TextDocumentContentProvider for source-generated files #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
commented
Sep 20, 2024
| vscode.workspace.registerTextDocumentContentProvider( | ||
| 'roslyn-source-generated', | ||
| new (class implements vscode.TextDocumentContentProvider { | ||
| async provideTextDocumentContent(uri: vscode.Uri, token: vscode.CancellationToken): Promise<string> { |
There was a problem hiding this comment.
we definitely need to add refresh support in. There is some interesting behavior where VSCode doesn't actually always call didClose on the document even if the only active view closes (it calls sometimes much later). So the content gets reused even if the view is closed and another go to def request is made.
I could implement a command to refresh, or refresh on textview changing, but IMHO we should just implement server side refresh instead.
This allows the Roslyn LSP to return document references with a roslyn-source-generated URI, and we'll turn around and ask the LSP for those files when they're opened. For now we don't worry about refreshing files if they've changed, just to keep this simple.
dibarbet
force-pushed
the
open_source_generated_documents
branch
from
da298f4
to
6a17673
Compare
JoeRobich
approved these changes
Oct 4, 2024
|
We should definitely have a test for this. I think it is fine if it comes in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6426
This allows the Roslyn LSP to return document references with a roslyn-source-generated URI, and we'll turn around and ask the LSP for those files when they're opened.
For now we don't worry about refreshing files if they've changed, just to keep this simple.
Requires dotnet/roslyn#75180