Update registerRelatedFilesProvider API #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu
changed the title
dibarbet
reviewed
Oct 3, 2024
| @@ -55,7 +63,7 @@ export function registerCopilotExtension(languageServer: RoslynLanguageServer, c | |||
| languageId: 'csharp', | |||
| }; | |||
|
|
|||
| relatedAPI.registerRelatedFilesProvider(id, async (uri, token) => { | |||
| relatedAPI.registerRelatedFilesProvider(id, async (uri, _, token) => { | |||
There was a problem hiding this comment.
Just want to confirm that we don't have issues with either
- An older copilot version calling into this. I would guess that it would pass in only two parameters, and the second (discarded) would actually be the cancellation token.
- A new copilot extension calling into an old C# version - where it would pass 3 parameters where we only are expecting two.
If the mismatch is being resolved elsewhere that is fine, but want to make sure.
There was a problem hiding this comment.
I tested both scenarios, they would at least return related files w/o error/crashing. Given that copilot releases at a fast cadence (once every couple of days) and the experiment would last until next C# extension stable release (in the experiment we would control which versions of C# extension to be part of it), I'm not very concerned about mismatch.
dibarbet
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which was changed recently in an internal repo (this and this)
FYI @sandersn